[ 
https://issues.apache.org/jira/browse/FLUME-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290854#comment-13290854
 ] 

Hari Shreedharan commented on FLUME-1260:
-----------------------------------------

I don't agree with having a build profile for rat. The reason as I posted on 
FLUME-1202 is:
If we move it to a different profile, we might end up committing code without 
these licenses. It is important that we don't do that. It is easy to miss the 
fact that there is no license on a new file, during the review. But there is no 
way you can miss a build failure due to missing license

So even if the contributor misses the licenses, the reviewer is not going to 
miss it when he builds for review. Trust me, people will forget to do a 
separate build for rat!
                
> Create separate nondefault build profile for rat
> ------------------------------------------------
>
>                 Key: FLUME-1260
>                 URL: https://issues.apache.org/jira/browse/FLUME-1260
>             Project: Flume
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Jarek Jarcec Cecho
>            Priority: Minor
>
> I see many people having issues with rat check during build lately (including 
> myself) which can be seen as a barrier for new contributors.
> I would like to suggest moving execution of rat into separate build profile 
> that won't be run by default. This new profile would be then used for 
> continuous integration and during release procedure.
> Jarcec

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to