[
https://issues.apache.org/jira/browse/FLUME-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293168#comment-13293168
]
Will McQueen commented on FLUME-1271:
-------------------------------------
+1 lgtm!
Patch applied, fix confirmed. Details:
Config used:
agent.channels = c1
agent.sources = r1
agent.sinks = k1
#
agent.channels.c1.type = MEMORY
#
#agent.sources.r1.channels = c1
agent.sources.r1.type = SEQ
#
agent.sinks.k1.channel = c1
agent.sinks.k1.type = LOGGER
2012-06-11 15:54:38,225 INFO lifecycle.LifecycleSupervisor: Starting lifecycle
supervisor 1
2012-06-11 15:54:38,226 INFO node.FlumeNode: Flume node starting - agent
2012-06-11 15:54:38,229 INFO nodemanager.DefaultLogicalNodeManager: Node
manager starting
2012-06-11 15:54:38,229 INFO lifecycle.LifecycleSupervisor: Starting lifecycle
supervisor 10
2012-06-11 15:54:38,229 INFO properties.PropertiesFileConfigurationProvider:
Configuration provider starting
2012-06-11 15:54:38,230 INFO properties.PropertiesFileConfigurationProvider:
Reloading configuration file:conf/flume.conf
2012-06-11 15:54:38,234 INFO conf.FlumeConfiguration: Processing:k1
2012-06-11 15:54:38,234 INFO conf.FlumeConfiguration: Processing:k1
2012-06-11 15:54:38,234 INFO conf.FlumeConfiguration: Added sinks: k1 Agent:
agent
2012-06-11 15:54:38,256 INFO conf.FlumeConfiguration: Post-validation flume
configuration contains configuration for agents: [agent]
2012-06-11 15:54:38,256 INFO properties.PropertiesFileConfigurationProvider:
Creating channels
2012-06-11 15:54:38,260 INFO properties.PropertiesFileConfigurationProvider:
created channel c1
2012-06-11 15:54:38,262 ERROR properties.PropertiesFileConfigurationProvider:
Failed to load configuration data. Exception follows.
java.lang.NullPointerException
at
org.apache.flume.conf.properties.PropertiesFileConfigurationProvider.loadSources(PropertiesFileConfigurationProvider.java:324)
at
org.apache.flume.conf.properties.PropertiesFileConfigurationProvider.load(PropertiesFileConfigurationProvider.java:222)
at
org.apache.flume.conf.file.AbstractFileConfigurationProvider.doLoad(AbstractFileConfigurationProvider.java:123)
at
org.apache.flume.conf.file.AbstractFileConfigurationProvider.access$300(AbstractFileConfigurationProvider.java:38)
at
org.apache.flume.conf.file.AbstractFileConfigurationProvider$FileWatcherRunnable.run(AbstractFileConfigurationProvider.java:202)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at
java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:317)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:150)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:98)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.runPeriodic(ScheduledThreadPoolExecutor.java:180)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:204)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
2012-06-11 15:54:46,449 INFO node.FlumeNode: Flume node stopping - agent
2012-06-11 15:54:46,449 INFO lifecycle.LifecycleSupervisor: Stopping lifecycle
supervisor 9
2012-06-11 15:54:46,451 INFO properties.PropertiesFileConfigurationProvider:
Configuration provider stopping
2012-06-11 15:54:46,451 INFO nodemanager.DefaultLogicalNodeManager: Node
manager stopping
2012-06-11 15:54:46,451 INFO lifecycle.LifecycleSupervisor: Stopping lifecycle
supervisor 9
After applying patch (using same config):
2012-06-11 15:58:37,005 INFO lifecycle.LifecycleSupervisor: Starting lifecycle
supervisor 1
2012-06-11 15:58:37,006 INFO node.FlumeNode: Flume node starting - agent
2012-06-11 15:58:37,008 INFO nodemanager.DefaultLogicalNodeManager: Node
manager starting
2012-06-11 15:58:37,008 INFO lifecycle.LifecycleSupervisor: Starting lifecycle
supervisor 10
2012-06-11 15:58:37,009 INFO properties.PropertiesFileConfigurationProvider:
Configuration provider starting
2012-06-11 15:58:37,010 INFO properties.PropertiesFileConfigurationProvider:
Reloading configuration file:conf/flume.conf
2012-06-11 15:58:37,014 INFO conf.FlumeConfiguration: Processing:k1
2012-06-11 15:58:37,014 INFO conf.FlumeConfiguration: Processing:k1
2012-06-11 15:58:37,014 INFO conf.FlumeConfiguration: Added sinks: k1 Agent:
agent
2012-06-11 15:58:37,024 WARN conf.FlumeConfiguration: Removed r1 due to Failed
to configure component!
2012-06-11 15:58:37,029 INFO conf.FlumeConfiguration: Post-validation flume
configuration contains configuration for agents: [agent]
2012-06-11 15:58:37,029 INFO properties.PropertiesFileConfigurationProvider:
Creating channels
2012-06-11 15:58:37,033 INFO properties.PropertiesFileConfigurationProvider:
created channel c1
2012-06-11 15:58:37,033 INFO sink.DefaultSinkFactory: Creating instance of sink
k1 typeLOGGER
2012-06-11 15:58:37,035 INFO nodemanager.DefaultLogicalNodeManager: Starting
new configuration:{ sourceRunners:{} sinkRunners:{k1=SinkRunner: {
policy:org.apache.flume.sink.DefaultSinkProcessor@6115273a counterGroup:{
name:null counters:{} } }}
channels:{c1=org.apache.flume.channel.MemoryChannel@33c282a1} }
2012-06-11 15:58:37,035 INFO nodemanager.DefaultLogicalNodeManager: Starting
Channel c1
2012-06-11 15:58:37,036 INFO nodemanager.DefaultLogicalNodeManager: Waiting for
channel: c1 to start. Sleeping for 500 ms
2012-06-11 15:58:37,536 INFO nodemanager.DefaultLogicalNodeManager: Starting
Sink k1
2012-06-11 15:58:41,784 INFO node.FlumeNode: Flume node stopping - agent
2012-06-11 15:58:41,785 INFO lifecycle.LifecycleSupervisor: Stopping lifecycle
supervisor 9
2012-06-11 15:58:41,787 INFO properties.PropertiesFileConfigurationProvider:
Configuration provider stopping
2012-06-11 15:58:41,788 INFO nodemanager.DefaultLogicalNodeManager: Node
manager stopping
2012-06-11 15:58:41,788 INFO lifecycle.LifecycleSupervisor: Stopping lifecycle
supervisor 9
> Incorrect configuration causes NPE
> ----------------------------------
>
> Key: FLUME-1271
> URL: https://issues.apache.org/jira/browse/FLUME-1271
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.1.0
> Reporter: Inder SIngh
> Assignee: Hari Shreedharan
> Priority: Trivial
> Fix For: v1.2.0
>
> Attachments: FLUME-1271.patch
>
>
> Problem Description
> ---------------------
> An incorrect configuration something like below can result in NPE in FLUME.
> agent1.sources.seqsource.type=seq
> #agent1.sources.seqsource.channels=ch1
> Exception Details
> -----------------
> 2012-06-11 15:08:28,748 ERROR properties.PropertiesFileConfigurationProvider:
> Failed to load configuration data. Exception follows.
> java.lang.NullPointerException
> at
> org.apache.flume.conf.properties.PropertiesFileConfigurationProvider.loadSources(PropertiesFileConfigurationProvider.java:324)
> at
> org.apache.flume.conf.properties.PropertiesFileConfigurationProvider.load(PropertiesFileConfigurationProvider.java:222)
> at
> org.apache.flume.conf.file.AbstractFileConfigurationProvider.doLoad(AbstractFileConfigurationProvider.java:123)
> at
> org.apache.flume.conf.file.AbstractFileConfigurationProvider.access$300(AbstractFileConfigurationProvider.java:38)
> Cause
> ------
> PropertiesFileConfigurationProvider->loadSources() {
> ...
> ...
> String[] channelNames = context.getString(
> BasicConfigurationConstants.CONFIG_CHANNELS).split("\\s+");
> ...
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
