[ 
https://issues.apache.org/jira/browse/FLUME-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293304#comment-13293304
 ] 

Mike Percy commented on FLUME-1216:
-----------------------------------

Hi Leslin,
Overall this looks good. I just have the following requests for this patch (all 
nit-picks):
1. Instead of logging the error and throwing, please just throw an exception 
with the desired message. It looks like the stack trace will be printed to the 
log by the config file poller, and Flume will not start, so that's all I was 
looking for originally.
2. Please include the proper level of indentation on the new lines 501-503 in 
HDFSEventSink.java
3. Please limit the line lengths to 80 characters in the Java code.

Thanks!
Mike
                
> Need useful error message when keytab does not exist
> ----------------------------------------------------
>
>                 Key: FLUME-1216
>                 URL: https://issues.apache.org/jira/browse/FLUME-1216
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>            Reporter: Mike Percy
>            Assignee: Leslin (Hong Xiang Lin)
>         Attachments: FLUME-1216.patch
>
>
> If keytab file does not exist, no useful error message is printed by HDFS sink

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to