-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5347/#review8309
-----------------------------------------------------------
Hi Mubarak,
Some comments:
1) Please add an entry to SinkType.java:
/**
* Redis Sink provided by org.apache.flume.sink.RedisSink
*/
REDIS("org.apache.flume.sink.RedisSink"),
2) Shouldn't SimpleRedisEventSerializer implement EventSerializer? As an
example, please see BodyTextEventSerializer and FlumeEventAvroEventSerializer.
3) Please add the appropriate entry in EventSerializerType.java:
REDIS(org.apache.flume.sink.SimpleRedisEventSerializer.Builder.class)
Do you agree with these changes?
Cheers,
Will
- Will McQueen
On June 17, 2012, 6:10 a.m., Mubarak Seyed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5347/
> -----------------------------------------------------------
>
> (Updated June 17, 2012, 6:10 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Redis supports pub/sub out-of-the-box. Flume based event streaming
> application can make use of Redis publisher sink to publish events to
> topic(s) in Redis and then subscriber(s) of topic/channel can receive events
> to do near real-time analytics.
>
>
> This addresses bug FLUME-1251.
> https://issues.apache.org/jira/browse/FLUME-1251
>
>
> Diffs
> -----
>
> trunk/flume-ng-dist/pom.xml 1345351
> trunk/flume-ng-sinks/flume-ng-redis-sink/pom.xml PRE-CREATION
>
> trunk/flume-ng-sinks/flume-ng-redis-sink/src/main/java/org/apache/flume/sink/RedisEventSerializer.java
> PRE-CREATION
>
> trunk/flume-ng-sinks/flume-ng-redis-sink/src/main/java/org/apache/flume/sink/RedisSink.java
> PRE-CREATION
>
> trunk/flume-ng-sinks/flume-ng-redis-sink/src/main/java/org/apache/flume/sink/SimpleRedisEventSerializer.java
> PRE-CREATION
>
> trunk/flume-ng-sinks/flume-ng-redis-sink/src/test/java/org/apache/flume/sink/redis/TestRedisSink.java
> PRE-CREATION
> trunk/flume-ng-sinks/pom.xml 1345351
> trunk/pom.xml 1345351
>
> Diff: https://reviews.apache.org/r/5347/diff/
>
>
> Testing
> -------
>
> Yes, tested in lab environment.
>
>
> Thanks,
>
> Mubarak Seyed
>
>
