> On June 20, 2012, 5:34 a.m., Hari Shreedharan wrote: > > +1. > > Please attach the patch to the jira.
Done. - Inder ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5418/#review8412 ----------------------------------------------------------- On June 19, 2012, 12:34 p.m., Inder Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5418/ > ----------------------------------------------------------- > > (Updated June 19, 2012, 12:34 p.m.) > > > Review request for Flume. > > > Description > ------- > > HDFSEvent Sink takes a property hdfs.fileType. > Currently the value can be either DataStream, SequenceFile, CompressedStream > > Suggestion as per the JIRA is to have the values case insensitive. > > > This addresses bug FLUME-1290. > https://issues.apache.org/jira/browse/FLUME-1290 > > > Diffs > ----- > > > trunk/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSWriterFactory.java > 1351585 > > Diff: https://reviews.apache.org/r/5418/diff/ > > > Testing > ------- > > 1. Existing FLUME tests > 2. Manual testing by specifying the config hdfs.fileType = datastream > > > Thanks, > > Inder Singh > >
