----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5463/#review8452 -----------------------------------------------------------
Hi Leslin, Thanks for the patch! I believe that the main idea behind this bug was to provide information similar to what Hadoop and Hbase provide: Hadoop 1.0.1 Subversion https://svn.apache.org/repos/asf/hadoop/common/branches/branch-1.0 -r 1243785 Compiled by hortonfo on Tue Feb 14 08:15:38 UTC 2012 >From source with checksum a83f68553fb7e4aef47fe859b9045edc or in case of Hbase: 12/06/21 01:17:11 INFO util.VersionInfo: HBase 0.92.1 12/06/21 01:17:11 INFO util.VersionInfo: Subversion https://svn.apache.org/repos/asf/hbase/branches/0.92 -r 1298924 12/06/21 01:17:11 INFO util.VersionInfo: Compiled by jenkins on Fri Mar 9 16:58:34 UTC 2012 You can take a look at Hadoop or Hbase code to see how it is done by them. Basically getting the svn info and the compilation time and user name is what was expected. - Hari Shreedharan On June 20, 2012, 11:44 p.m., Leslin (Hong Xiang Lin) wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5463/ > ----------------------------------------------------------- > > (Updated June 20, 2012, 11:44 p.m.) > > > Review request for Flume. > > > Description > ------- > > Add feature to let flume-ng get version info: > eslin@ubtServer:/usr/lib/flume-ng/bin$ flume-ng version > Apache Flume version: 1.2.0-incubating-SNAPSHOT > Built-By: 1.2.0-incubating-SNAPSHOT > > > This addresses bug FLUME-1240. > https://issues.apache.org/jira/browse/FLUME-1240 > > > Diffs > ----- > > bin/flume-ng 24a7d95 > flume-ng-core/src/main/java/org/apache/flume/tools/VersionInfo.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/5463/diff/ > > > Testing > ------- > > Test with: > flume-ng version > flume-ng agent -n agent -f /usr/lib/flume-ng/conf/flume-conf.properties > > > Thanks, > > Leslin (Hong Xiang Lin) > >
