> On June 22, 2012, 12:56 a.m., Hari Shreedharan wrote: > > Generally looks good. I would like to still a unit test that actually > > verifies correctness. If possible, could you add one?
Hari, thanks for looking. I've filed a follow-up JIRA FLUME-1307 to track improving the unit test. It would be great if we can do that as a next step. - Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5481/#review8470 ----------------------------------------------------------- On June 21, 2012, 11:21 a.m., Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5481/ > ----------------------------------------------------------- > > (Updated June 21, 2012, 11:21 a.m.) > > > Review request for Flume. > > > Description > ------- > > HDFSCompressedDataStream can lose data. Details in the JIRA. > > > This addresses bug FLUME-1301. > https://issues.apache.org/jira/browse/FLUME-1301 > > > Diffs > ----- > > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSCompressedDataStream.java > 9d63110 > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSCompressedDataStream.java > PRE-CREATION > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSinkOnMiniCluster.java > 4d16d6e > > Diff: https://reviews.apache.org/r/5481/diff/ > > > Testing > ------- > > Added a unit test. Also, manual inspection & verification. > > > Thanks, > > Mike Percy > >
