Re: Review Request: FLUME-1154: flume-ng script should first try finding java from PATH and then try using bigtop, instead of vice-versa

[Leslin]

Hi,


2012/6/23 Will McQueen <w...@cloudera.com>

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5466/#review8490
> -----------------------------------------------------------
>
> Ship it!
>
>
> lgtm! Thanks Leslie.
>
> - Will McQueen
>
>
> On June 22, 2012, 3:07 p.m., Leslin  (Hong Xiang Lin) wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/5466/
> > -----------------------------------------------------------
> >
> > (Updated June 22, 2012, 3:07 p.m.)
> >
> >
> > Review request for Flume.
> >
> >
> > Description
> > -------
> >
> > Change flume-ng script to find java from PATH first instead of using
> bigtop-detect-javahome to get when JAVA_HOME does not set. It will helpful
> in multi-java environment.
> >
> >
> > This addresses bug FLUME-1154.
> >     https://issues.apache.org/jira/browse/FLUME-1154
> >
> >
> > Diffs
> > -----
> >
> >   bin/flume-ng 24a7d95
> >
> > Diff: https://reviews.apache.org/r/5466/diff/
> >
> >
> > Testing
> > -------
> >
> > test with normal start agent
> >
> >
> > Thanks,
> >
> > Leslin  (Hong Xiang Lin)
> >
> >
>
>


-- 



Best Regards

Leslin