----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5405/#review8523 -----------------------------------------------------------
Ship it! ok, looks good to go. If you can comment out the test that needs to run last and attach the patch to the jira, I'll go ahead and commit it - Juhani Connolly On June 18, 2012, 10:49 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5405/ > ----------------------------------------------------------- > > (Updated June 18, 2012, 10:49 p.m.) > > > Review request for Flume. > > > Description > ------- > > Make sure table and column family exists in start(). > > > This addresses bug FLUME-1288. > https://issues.apache.org/jira/browse/FLUME-1288 > > > Diffs > ----- > > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java > d08d7a7 > > flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java > 3de651f > > Diff: https://reviews.apache.org/r/5405/diff/ > > > Testing > ------- > > Added several more unit tests. > > > Thanks, > > Hari Shreedharan > >
