----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5570/#review8582 -----------------------------------------------------------
Ship it! +1 I need this patch so committing it... lgtm... Brock, as with the rest of these patches, please raise any issues and I will follow up. - Mike Percy On June 26, 2012, 5:01 a.m., Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5570/ > ----------------------------------------------------------- > > (Updated June 26, 2012, 5:01 a.m.) > > > Review request for Flume and Brock Noland. > > > Description > ------- > > Fixed replay logic to replay after the last recorded checkpoint in the log if > that happens to be before the queue's checkpoint. This will speed up the > restarts considerably in case the channel was shutdown in the middle of a > checkpoint. > > Also found and fixed a problem with acquiring a lock during the get operation > which could interfere with checkpoint in progress. > > > This addresses bug FLUME-1319. > https://issues.apache.org/jira/browse/FLUME-1319 > > > Diffs > ----- > > > /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > 1353634 > > /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java > 1353634 > > Diff: https://reviews.apache.org/r/5570/diff/ > > > Testing > ------- > > Running tests and will be doing manual tests soon. > > > Thanks, > > Arvind Prabhakar > >
