----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5585/#review8644 -----------------------------------------------------------
Thx for the catch Hari, updated patch. - Mike Percy On June 26, 2012, 11:08 p.m., Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5585/ > ----------------------------------------------------------- > > (Updated June 26, 2012, 11:08 p.m.) > > > Review request for Flume. > > > Description > ------- > > FileChannel contains an unnecessary shutdown hook. This patch removes it. > stop() relies on being called from the DefaultLogicalNodeManager or > LifecycleSupervisor. > > > This addresses bug FLUME-1323. > https://issues.apache.org/jira/browse/FLUME-1323 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 9c56b31 > > Diff: https://reviews.apache.org/r/5585/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Mike Percy > >
