----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5603/#review8652 -----------------------------------------------------------
Thanks for the patch Hari. Can you please explain in more details what the issue is and how does this change help? In case we do proceed with this change, my suggestion is to make the timeout configurable instead of hardcoding a particular value. - Arvind Prabhakar On June 27, 2012, 5:10 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5603/ > ----------------------------------------------------------- > > (Updated June 27, 2012, 5:10 a.m.) > > > Review request for Flume, Arvind Prabhakar and Brock Noland. > > > Description > ------- > > writeCheckpoint now times out on the lock. > > > This addresses bug FLUME-1327. > https://issues.apache.org/jira/browse/FLUME-1327 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > b905db5 > > Diff: https://reviews.apache.org/r/5603/diff/ > > > Testing > ------- > > All unit tests pass. > > > Thanks, > > Hari Shreedharan > >
