-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5614/
-----------------------------------------------------------
(Updated June 27, 2012, 10:53 p.m.)
Review request for Flume.
Changes
-------
Thanks Hari & Mubarak for the review!
Changes:
- Remove unused imports (thought I had done that, not sure what happened)
- Catch CancellationException & RejectedException
Description
-------
Avro RPC has an issue where the Avro sink can hang during the RPC handshake.
This patch is a workaround for the problem (as opposed to a fix for the
underlying problem). I still think we should fix the underlying problem and
remove this workaround at a later date.
While I was in the RPC client fixing stuff and improving the exception
messages, I went ahead and improved the exception/log messages in the avro sink
as well.
This addresses bug FLUME-1329.
https://issues.apache.org/jira/browse/FLUME-1329
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java 80b1d27
flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java
b7eca53
flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientFactory.java 5b289e7
Diff: https://reviews.apache.org/r/5614/diff/
Testing
-------
Unit tests pass.
Thanks,
Mike Percy
