----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5622/#review8683 -----------------------------------------------------------
lgtm. Minor comments related to rpc failure counts. flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java <https://reviews.apache.org/r/5622/#comment18346> counterGroup.incrementAndGet("rpc.failure"); flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java <https://reviews.apache.org/r/5622/#comment18345> I think we are not counting the RPC batch failure here counterGroup.incrementAndGet("rpc.batch.failure"); - Mubarak Seyed On June 27, 2012, 11:59 p.m., Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5622/ > ----------------------------------------------------------- > > (Updated June 27, 2012, 11:59 p.m.) > > > Review request for Flume. > > > Description > ------- > > This patch uses a cached thread pool for boss threads in Netty instead of a > fixed size pool of maxThreads size. It also improves some error messages in > the AvroSource. > > Additionally, I improved the error messages in ChannelProcessor (now includes > channel name in error messages) and made sure that it catches Throwable in > the non-batch case. > > > This addresses bug FLUME-1330. > https://issues.apache.org/jira/browse/FLUME-1330 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java > 07b04e2 > flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java > c89eeb6 > flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 1d68d87 > > Diff: https://reviews.apache.org/r/5622/diff/ > > > Testing > ------- > > Unit tests pass. > > > Thanks, > > Mike Percy > >
