----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5641/#review8719 -----------------------------------------------------------
You are explicitly checking for NoClassDefFoundError and flagging that as unrecoverable. By definition, all Errors are unrecoverable so I would recommend just checking for that. - Ralph Goers On June 28, 2012, 8:16 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5641/ > ----------------------------------------------------------- > > (Updated June 28, 2012, 8:16 a.m.) > > > Review request for Flume. > > > Description > ------- > > A very hacky patch to log an error if start throws NoClassDefFoundError. If a > channel's start throws, this patch ensures that the conf-poller thread will > not wait indefinitely for the channel to start. > > > This addresses bug FLUME-1331. > https://issues.apache.org/jira/browse/FLUME-1331 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java > 2935e64 > > flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java > 555de8b > > Diff: https://reviews.apache.org/r/5641/diff/ > > > Testing > ------- > > > Thanks, > > Hari Shreedharan > >
