----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5746/#review8876 -----------------------------------------------------------
/trunk/flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java <https://reviews.apache.org/r/5746/#comment18911> We could just move the Long.valueOf call here, thus needing only one try-catch-throw. /trunk/flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java <https://reviews.apache.org/r/5746/#comment18910> Shouldn't the exception be caught here as well? I think a better approach is to check where if timestampHeader is null/non-numeric value. If it is null, you can throw the exception there itself, rather than having multiple checks later. - Hari Shreedharan On July 4, 2012, 2:23 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5746/ > ----------------------------------------------------------- > > (Updated July 4, 2012, 2:23 p.m.) > > > Review request for Flume. > > > Description > ------- > > I've added catch block that will repack NumberFormatException into > RuntimeException with helpful error message. > > > This addresses bug FLUME-1338. > https://issues.apache.org/jira/browse/FLUME-1338 > > > Diffs > ----- > > > /trunk/flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java > 1357243 > > Diff: https://reviews.apache.org/r/5746/diff/ > > > Testing > ------- > > mvn test > > > Thanks, > > Jarek Cecho > >
