DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24775>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24775 [PATCH] padding-left in PDF Renderer ------- Additional Comments From [EMAIL PROTECTED] 2003-11-25 22:53 ------- "The PDF Renderer does override renderBlockViewport method, but the code in the super class method is copied to a large extent." Oh--I wasn't looking in PDFRenderer for the redundancy. I was looking at renderBlocks(), renderBlock(), and renderBlockViewPort() of AbstractRenderer-- i.e., where you told me to look in your elaboration below. (I had assumed, then, that the duplication was among those three methods.) I asked you: "Please clarify *which* methods had the duplication so I can zoom in immediately to what you are talking about--patches--until applied--rarely immediately inform us of that!" Your response did not answer that question--worse, it put me on the wrong track. That sentence you wrote above--finally explaining where the duplication was--I wish you had written that instead. It would have saved me a lot of time and energy. Try to be more precise next time... [At any rate, it would appear the child classes would be the better place to remove redundant code, not the base, so I probably would have skipped the changes anyway.] Thanks, Glen
