DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=28237>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=28237 [PATCH] Use the commons logging LogFactory also in Fop.java ------- Additional Comments From [EMAIL PROTECTED] 2004-04-17 08:36 ------- Simon (and others), For the remaining three issues remaining, please take a look at the patch I just added. 1.) I removed the -debug and -quiet options, because they just cover over the commons-logging settings. Also I'm leery of switching to SimpleLog as a default, seeing the Commons Logging will normally use JDK1.4 logging. Rather than use an API that covers up Commons-Logging functionality (i.e., -d and -q), I would rather have us make it very simple for the user to use/learn the exact commons-logging method, which brings up: 2.) In fop.bat and fop.sh, (I only tested the former, I'll need someone to check the latter), I created commented-out lines that will allow the user to choose a different logger from the default JDK1.4 and the logging level (the latter, iff they're using SimpleLog). 3.) Per your last comment below, on using .info() instead of .debug() in the dumpConfiguration() nee debug() method--I agree, that should be the message level instead because that is what the user is specifically requesting. My patch does this, but without switching to a SimpleLog() to guarantee output. The drawback is that if the user specifically chooses "error" or "fatal", etc., as a level, that will take precedence over setting this field, and as a consequence this information won't be shown. OTOH, the logger that the user specifically chose externally won't be overridden. I suspected the latter was the lesser of two evils, and so went with that. Your thoughts? Thanks, Glen
