DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=38282>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38282 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17426|0 |1 is obsolete| | ------- Additional Comments From [EMAIL PROTECTED] 2006-01-29 21:49 ------- Created an attachment (id=17530) --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17530&action=view) alternative patch Gerhard, I finally got around to taking a look at the column-numbers again. In the end, I think the solution was pretty straightforward (see attached patch). I managed to make the function applicable to table-cells as well... I only needed to make sure column-number and number-columns-spanned were treated the same way as font-size (see alterations to PropertyList). Maybe in the longer term, some rational ordering of the possibly specified properties needs to be looked at in a more global sense. (Apart from the above three, are there any other cases where the property parsing implies knowing the explicit values for other properties, so we need to make sure they are available first?) Roughly, I think my patch does more or less the same as yours. Differences are: * that I preferred to expose the isColumnNumberUsed() method, instead of using iterators over the columns List (a matter of taste? seemed to result in less objects being created...) * replaced the PropertyList reference in TableColumn with a StaticPropertyList (efficiency+) * did some cleanup: moved validation/overlapping colnrs to the PropertyMaker Let me know if this agrees with you... Cheers, Andreas -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
