DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40288>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40288





------- Additional Comments From [EMAIL PROTECTED]  2007-02-27 05:07 -------
(In reply to comment #12)
> Isn't a full URL, that is a URL pointing to a file resource a legal base URL
> which will now fail? For example if I set the base URL to the file I am
> processing, lets say 'file:///home/mm/test.xml' the previous version would
> accept that and resolve references relative to that while now we are 
> appending a
> / and it will fail.

Indeed, and I was also concerned by that at the beginning. But that code is used
only to handle the <base> and <font-base> elements in the user config file,
where it would be really unusual to see URLs pointing to files instead of
directories. And anyway such cases would happen with power users having a good
understanding of relative URL resolution. If they have the full URL in the error
message, they will understand that they have to remove the last part of it to
make the thing work. So this change looks safe to me.
Now if a majority of the developers have concerns about that I can revert it. We
can also move that piece of code to the place where base/font-base are 
retrieved.

WDYT?
Vincent

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to