Vincent, can I please ask you to put code guards (if (log.isDebugEnabled())...) around debug and trace log statements? This avoids unnecessary string concatenation if the respective log level is diabled. See also: http://jakarta.apache.org/commons/logging/guide.html#Code_Guards
Thanks! On 27.02.2007 15:50:56 vhennebert wrote: > Author: vhennebert > Date: Tue Feb 27 06:50:52 2007 > New Revision: 512266 > > URL: http://svn.apache.org/viewvc?view=rev&rev=512266 > Log: > Add log messages to help understand the code > > Modified: > > xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java > > Modified: > xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java > URL: > http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java?view=diff&rev=512266&r1=512265&r2=512266 > ============================================================================== > --- > xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java > (original) > +++ > xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java > Tue Feb 27 06:50:52 2007 <snip/> > @@ -238,6 +238,7 @@ > borderBefore[column] = > pgu.getBorders().getBorderBeforeWidth(false); > } else { > borderBefore[column] = > pgu.getBorders().getBorderBeforeWidth(false) / 2; > + log.trace("border before for column " + column + ": " + > borderBefore[column]); > } > paddingBefore[column] = pgu.getBorders().getPaddingBefore(false, > pgu.getCellLM()); > paddingAfter[column] = pgu.getBorders().getPaddingAfter(false, > pgu.getCellLM()); <snip/> Jeremias Maerki
