DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=41831>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41831 ------- Additional Comments From [EMAIL PROTECTED] 2007-03-15 03:13 ------- Hi Andreas, Thanks for trying out the patch :-). (In reply to comment #7) > Adrian, > > After applying the changes in the patch, it /seems/ to work... only, I can't find a TTF file on my system > for which I get no complaints (about ascender/descender conflicts, or absent unicode cmaps) > Must be something Mac-related (? or did you test on that platform yet?) It is good that you are a Mac user as I was unable to test on the Mac. The Mac native font finder should examine the following folders (not recursively) in order to search for available system fonts :- "~/Library/Fonts/", // user "/Library/Fonts/", // local "/Network/Library/Fonts/", // network "/System/Library/Fonts/", // system "/System Folder/Fonts/" // classic If I could also have some feedback from unix users that would be great. > As for the fine-tuning: > I get a few SEVERE errors when the MacFontInfoFinder wants to access directories that don't exist. > Those need to be suppressed. I have now suppressed this behaviour and will add it to the next patch submission. > I'm also not too sure I like the idea of automatically /loading/ all the present fonts... Take care of what > FontLoader does. It reads the whole TTF-file into a byte array, and some Unicode fonts are rather large > beasts to read into memory entirely. If you have a few of those installed...? > I'd try to limit it to the fonts that will actually be used, i.e. keep the possibly used font-info cached, but > only trigger loading the font during property-resolving when the corresponding font-family is > encountered. The fonts should only be loaded the first time you run FOP in autodetect and cache mode. After this first run, all the font info should be stored in the fop.cache (should be created in fop/conf/fop.cache) and subsequent FOP executions should make use of the cache. Even though this detection is only expensive at the first time of execution, I take your point on board and am considering lightening the font loading for this autodetect purpose - maybe a call along the lines of FontLoader.loadLightFont(fontFile, resolver) - I may add this in the next patch update. > As you indicated, a bit of tweaking and tuning necessary, but all in all 'Nice Job!'. Yes I think there will be some more tweaking, the more people try this patch out the better - I am sure there will be some things I haven't considered. Cheers, Adrian. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
