I notice a few new findbugs errors creeping into trunk. Please try to run the findbugs target before commiting in order to fix any newly introduced bugs. Here are the new ones I see:
> <a href="#MS_SHOULD_BE_FINAL">Bug type MS_SHOULD_BE_FINAL (click for details)</a> > <br/>In class org.apache.fop.render.rtf.rtflib.rtfdoc.RtfTextrun<br/>Field org.apache.fop.render.rtf.rtflib.rtfdoc.RtfTextrun.log<br/>At RtfTextrun.java:[line 57]</p> > <a href="#DM_NUMBER_CTOR">Bug type DM_NUMBER_CTOR (click for details)</a> > <br/>In class org.apache.fop.render.rtf.rtflib.rtfdoc.RtfTextrun<br/>In method org.apache.fop.render.rtf.rtflib.rtfdoc.RtfTextrun.addParagraphBreak()<br/>Called method new Integer(int)<br/>Should cal\ l Integer.valueOf(int) instead<br/>At RtfTextrun.java:[line 304]</p> > <a href="#DLS_DEAD_LOCAL_STORE">Bug type DLS_DEAD_LOCAL_STORE (click for details)</a> > <br/>In class org.apache.fop.render.rtf.rtflib.rtfdoc.RtfTextrun<br/>In method org.apache.fop.render.rtf.rtflib.rtfdoc.RtfTextrun.addString(String)<br/>Local variable named r<br/>At RtfTextrun.java:[\ line 274]</p> After fixing the above three, there should remain 1048 errors/warnings reported by findbugs in trunk. It would be nice if we could eliminate all of these (either by fixing or by adding exclusions to findbugs-exclude.xml), as it is much easier to check for new ones if there are none to start with. Regards, Glenn