Hi Mehdi,
I'm trying to assess the impact on our code if any.
It seems we just use the FOPFactory and don't directly construct a renderer so
this change will have *no* impact on our code.
The factory to get a new Fop already has foUserAgent in the constructor, so
nothing has changed in this regard, for example:
Fop fop = fopFactory.newFop(MimeConstants.MIME_PDF, foUserAgent,
out);
I've examined your diff, and unless I'm mistaken nothing in it impacts our
client-server that accepts requests for FOP rendering via TCP/IP.
You aren't changing how the FOPFactory is instantiated or how the FOP factory
is used to instantiate Fops.
I can't assess the impact on other people's applications but the impact on our
application seems non-existent.
Best Regards,
Jonathan Levinson
Senior Software Developer
Object Group
InterSystems
+1 617-621-0600
[email protected]
http://www.intersystems.com/summit2012/
> -----Original Message-----
> From: [email protected] [mailto:[email protected]]
> Sent: Wednesday, January 25, 2012 6:19 AM
> To: [email protected]
> Subject: DO NOT REPLY [Bug 52513] [PATCH] Moving FOUserAgent to the
> constructor of Renderers
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=52513
>
> --- Comment #2 from Mehdi Houshmand <[email protected]> 2012-01-25
> 11:19:00 UTC --- Since there doesn't seem to be any strong opposition to this
> change, I'll start a lazy consensus (i.e. apply the patch in 72hrs
> henceforth) to
> allow people to discuss any objections they may have.
>
> --
> Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> ------- You are receiving this mail because: ------- You are the assignee for
> the
> bug.
