What do you mean by "moved to build/gensrc"? There is no build/gensrc directory in the FOP source tree.
Are you suggesting it be regenerated at build time? If so, then that would slow the build process unnecessarily since it requires downloading data from the unicode web site. Further, there is no logical need to regenerate it at build time any more than there is a need to rebuild LineBreakUtils.java. None of the rationale you provide below are compelling. So I object to this proposed change. On Thu, Nov 22, 2012 at 2:52 AM, Vincent Hennebert <[email protected]>wrote: > Hi, > > I’ve recently stumbled upon this o.a.f.complexscripts.bidi.BidiClass > that appears to be generated. I think it should be moved to the > build/gensrc directory. Reasons are: > • It doesn’t need to be understood and maintained by developers in the > same way as other classes. Changes will be made to the generator and > not this class. Therefore it doesn’t need to follow the usual style > and readability rules. > • Despite the warning at the beginning of the class, there is still > a risk that it is accidentally modified during some refactoring > session. > • There is also a risk that the generator is modified and this class not > re-generated, introducing a discrepancy that may take some time to be > tracked down. > > Like any other generated file, I think the generation should happen at > any clean build. > > Any objection? > > Thanks, > Vincent >
