Simon, Could you revert this? Or I will. I'm in the process of cleaning up findbugs warnings, and not yet finished. You need to give me a little time to complete this work before changing the findbugs config. Feel free to use a private copy of your own however in the meantime.
G. On Thu, Sep 4, 2014 at 5:24 AM, <sstei...@apache.org> wrote: > Author: ssteiner > Date: Thu Sep 4 12:24:01 2014 > New Revision: 1622466 > > URL: http://svn.apache.org/r1622466 > Log: > Add temp findbugs excludes so we can start to fail on warnings > > Modified: > xmlgraphics/fop/trunk/findbugs-exclude.xml > > Modified: xmlgraphics/fop/trunk/findbugs-exclude.xml > URL: > http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/findbugs-exclude.xml?rev=1622466&r1=1622465&r2=1622466&view=diff > > ============================================================================== > --- xmlgraphics/fop/trunk/findbugs-exclude.xml (original) > +++ xmlgraphics/fop/trunk/findbugs-exclude.xml Thu Sep 4 12:24:01 2014 > @@ -228,6 +228,43 @@ > <!-- 58 warnings --> > <Bug pattern="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/> > </Match> > + <Match> > + <Bug pattern="UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD"/> > + </Match> > + <Match> > + <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/> > + </Match> > + <Match> > + <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD"/> > + </Match> > + <Match> > + <Bug pattern="DM_DEFAULT_ENCODING"/> > + </Match> > + <Match> > + <Bug pattern="BC_UNCONFIRMED_CAST"/> > + </Match> > + <Match> > + <Bug pattern="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/> > + </Match> > + <Match> > + <Bug pattern="SE_BAD_FIELD_STORE"/> > + </Match> > + <Match> > + <Bug pattern="BC_BAD_CAST_TO_CONCRETE_COLLECTION"/> > + </Match> > + <Match> > + <Bug pattern="NP_LOAD_OF_KNOWN_NULL_VALUE"/> > + </Match> > + <Match> > + <Bug pattern="OS_OPEN_STREAM_EXCEPTION_PATH"/> > + </Match> > + <Match> > + <Bug pattern="DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS"/> > + </Match> > + <Match> > + <Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE"/> > + </Match> > + > <!-- END - TEMPORARY (UNAPPROVED) EXCLUSIONS --> > > </FindBugsFilter> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: fop-commits-unsubscr...@xmlgraphics.apache.org > For additional commands, e-mail: fop-commits-h...@xmlgraphics.apache.org > >
