On Tue, Mar 29, 2016 at 1:59 AM, Simon Steiner <simonsteiner1...@gmail.com> wrote:
> Hi, > > After this change findbugs is always run for example: mvn clean install > -DskipTests > This doesn’t work on java 8 and takes much longer to run. > I agree with Simon. It is preferable to explicitly specify a findbugs goal when performing compile or install. The more standard process is to have findbugs run automatically when running the site phase. > > Thanks > > -----Original Message----- > From: cbowdi...@apache.org [mailto:cbowdi...@apache.org] > Sent: 24 March 2016 16:17 > To: fop-comm...@xmlgraphics.apache.org > Subject: svn commit: r1736460 - /xmlgraphics/fop/trunk/fop-core/pom.xml > > Author: cbowditch > Date: Thu Mar 24 16:16:47 2016 > New Revision: 1736460 > > URL: http://svn.apache.org/viewvc?rev=1736460&view=rev > Log: > Avoid the need to run checkstyle and findbugs separately and integrate > them into the build process; checkstyle runs in validate (pre-compile) > phase and findbugs runs in verify (post-compile) phase > > Modified: > xmlgraphics/fop/trunk/fop-core/pom.xml > > Modified: xmlgraphics/fop/trunk/fop-core/pom.xml > URL: > http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/fop-core/pom.xml?rev=1736460&r1=1736459&r2=1736460&view=diff > > ============================================================================== > --- xmlgraphics/fop/trunk/fop-core/pom.xml (original) > +++ xmlgraphics/fop/trunk/fop-core/pom.xml Thu Mar 24 16:16:47 2016 > @@ -300,6 +300,7 @@ > </plugin> > <!-- code analysis - checkstyle --> > <plugin> > + <groupId>org.apache.maven.plugins</groupId> > <artifactId>maven-checkstyle-plugin</artifactId> > <configuration> > > > <configLocation>${project.baseUri}src/tools/resources/checkstyle/checkstyle.xml</configLocation> > @@ -311,6 +312,15 @@ > > > <suppressionsLocation>${project.baseUri}src/tools/resources/checkstyle/suppressions.xml</suppressionsLocation> > <violationSeverity>warning</violationSeverity> > </configuration> > + <executions> > + <execution> > + <id>validate</id> > + <phase>validate</phase> > + <goals> > + <goal>check</goal> > + </goals> > + </execution> > + </executions> > </plugin> > <!-- code analysis - findbugs --> > <plugin> > @@ -322,6 +332,15 @@ > <effort>Max</effort> > <threshold>Low</threshold> > </configuration> > + <executions> > + <execution> > + <id>verify</id> > + <phase>verify</phase> > + <goals> > + <goal>check</goal> > + </goals> > + </execution> > + </executions> > </plugin> > </plugins> > <resources> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: fop-commits-unsubscr...@xmlgraphics.apache.org > For additional commands, e-mail: fop-commits-h...@xmlgraphics.apache.org > > >
