Hi Karl On 27.03.2006 05:39:01 Karl Roberts wrote: > Hi Jeremias, > Don't worry next time I'll create a patch for bugzilla! :-) > Where are the changes so I can test them?
In our Subversion repository in "Trunk", of course. See: http://xmlgraphics.apache.org/fop/download.html#source You should download the latest sources using Subversion. > I am not using FOUserAgent more than once per rendering run. > > The ThreadLocal stuff was there to guarantee that the FOUserAgent being > used was thread safe, when the > "FontReder.createFont(String path)" method calls > "AgentHelper.getInstance().getFOUserAgent()". Ah, I see. FontReader (or any other class from the font package for that matter) should not reference FOUserAgent. That's why I added the FontResolver. The DefaultFontResolver in the render package contains the reference to FOUserAgent to keep the dependencies clean. > The reason is because I am using FOP embedded from within a clustered > Web App environment and putting a ServletContextURIReader in > FOUserAgent. ServletContextURIReader has a reference to the > ServletContext in it's constructor, and so I just wanted to guarantee > that the FOUserAgent I'm using had the same ServletContext reference if > it was pre-empted, given that the AgentHelper uses a static Singleton. Looks too complicated to me. It's probably better to add a setter method to ServletContextURIResolver (not "Reader"!) to update the ServletContext if that changes. This can be done in the doGet() method. When I've finished my current task of merging our API finalization branch back into Trunk, I'll do that, too. > If the UserAgent had been referencable to "FontReder.createFont(String > path)" I'd have used it. <snip/> Jeremias Maerki --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
