On 30 Nov 2008, at 02:33, Peter Coppens wrote:

Hi Peter

I have something that seems to be working, but I am not sure it is always
correct and I doubt it's the most optimal approach.

Thanks for the effort in investigating a fix!



Here are the changes I did

1. PDFLink#toPDFString
Added

       this.action.setParent(this);

(would be better to do this when creating the PDFUri object )

Or maybe, we should do this in PDFLink#setAction() ?

That seems to be the point where the PDFAction (PDFUri) is associated with the PDFLink.

I already checked whether this had unwanted side-effects when the same URI is used in multiple links, but that does not seem to be the case. The parent link is only used to get to the ancestor document, which is obviously the same for all links.


2. PDFUri#getAction
<snip />
3. Added PDFObject#encodeText2

I'm wondering to what extent this new, separate method could be merged with the original encodeText(), maybe by changing the signature, and adding a second parameter to distinguish this case from the one covered by the original method.

Anyway, this is all going a bit OT for the users-list. You're welcome to add any progress/potential patches to the Bugzilla entry directly. That way, when someone finally wants to address it, he doesn't have to delve through the list-archives... :-)

I'll take care of adding these recent comments to the issue report.


Thanks again for your input! A fix for this seems to be much closer now.


Cheers

Andreas

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to