I think the main benefit is consistency. It makes working across foreman projects much easier if we have a common style. It’s an extreme case but I’ve had to work on foreman_tasks before and using a different style was a pain point. A lot of the obscure and convoluted syntaxes in foreman_tasks that make it hard to read could have been prevented by using some of these rubocop style cops:
https://git.io/voOVb http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/LambdaCall <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/LambdaCall> David On Thu, Jun 9, 2016 at 10:24 AM, Marek Hulán <[email protected]> wrote: > My opinion is obviously +1 :-) The reason why I don't like this cop is > that I > don't see any benefit of forbidding aliases that people widely use. I don't > think we should dictate whether to use map vs collect, find_all vs select, > find > vs detect etc. > > -- > Marek > > On Thursday 09 of June 2016 15:38:28 Marek Hulán wrote: > > Hello devs, > > > > I'd like to disable a style cop Style/ClassCheck which enforces using > is_a? > > instead of kind_of?. Please vote with +1 / -1 either here or in the PR > > > > https://github.com/theforeman/foreman/pull/3582 > > > > Thank you > > > > -- > > Marek > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
