On 06/07, Daniel Lobato Garcia wrote: > Reminder - 2 days left if you have any objections or comments!
Done! Welcome to the core team and may Jenkins help you with your code reviews :) > > On 06/02, Daniel Lobato Garcia wrote: > > Hi devs, > > > > I'd like to nominate Timo Goebel (timogoebel on Github & IRC) for commit > > access to theforeman/foreman repo. > > > > He's been contributing to the puppet modules, community-templates, bootdisk > > and Foreman for some time, particularly on the VMWare/vsphere side of > > things. > > He's been running Foreman on production for years already and gave > > local talks about it.(www.meetup.com/AWS-Meetup-Karlsruhe/events/229036956/) > > > > Most importantly and the reason why I thought of him as a person that > > could become a committer is his involvement on ipv6 support lately, > > where he's been submitting consistently good code. > > > > I think he understands very well the problem domain, and he will be > > committed to maintain and improve the code quality of the project, as > > well as providing good feedback from a production installations. > > > > Some examples of his contributions: > > > > https://github.com/theforeman/foreman/pull/3420 > > https://github.com/theforeman/foreman/pull/3424 > > https://github.com/theforeman/foreman/pull/3498 > > https://github.com/theforeman/foreman/pull/3499 > > https://github.com/theforeman/foreman/commit/5131edbfab258c0862c987f238049ee81a1cd13f > > https://github.com/theforeman/foreman/commit/8ca6c6bbc5242c29a8039d1e6a1d09d1a454164c > > https://github.com/theforeman/foreman/commit/2328beb569d3f0e51043202d3a00a3b30879d244 > > https://github.com/theforeman/puppet-puppet/pull/389 > > https://github.com/theforeman/foreman_bootdisk/pull/19 > > > > Lastly I'd encourage him to start reviewing already! > > > > Objections or comments in private are welcome, but public replies to this > > thread are preferred :) > > > > Best, > > > > -- > > Daniel Lobato Garcia > > > > @dLobatog > > blog.daniellobato.me > > daniellobato.me > > > > GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30 > > Keybase: https://keybase.io/elobato > > > > -- > Daniel Lobato Garcia > > @dLobatog > blog.daniellobato.me > daniellobato.me > > GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30 > Keybase: https://keybase.io/elobato -- Daniel Lobato Garcia @dLobatog blog.daniellobato.me daniellobato.me GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30 Keybase: https://keybase.io/elobato -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: PGP signature
