Hello I have few more findings with the latest version, please find them below in text. Some of them might need fixing in API rather than here. Feel free to just create redmine issue from them in such case. Once below comments are fixed I think we can move it under theforeman org (unless someone objects).
On Friday 13 of May 2016 03:59:18 oprazak wrote: > Thanks for comments, I made some changes and took care of the following: > > * scap-content update -h displays --new-name without any help, using it > > > fails > > hammer scap-content update --id 1 --new-name test23 > > results in 400 > The name option was added by default and I did not notice. It is removed > since scap content has only title. > > * updating scap-content file does not seem to work > > > hammer scap-content update --id 1 --scap-file > > /usr/share/xml/scap/ssg/content/ssg-centos6-ds.xml > > results in 400 > > Uploading files should work properly for both create and update commands. > > * scap-content is missing create and info commands, there's currently no > > > way > > to display associated orgs and locs > > > > * scap-content info should also display profile ids, otherwise I can't > > create > > policy > > I added the missing commands and we can view profile_ids and taxonomies. the info command lists --name but that does not work, it does not list --title which is required to search for scap-content by title > > * policy create allows to specify weekday as 1, update forces me to > > specify > > monday > > I think this is a problem of foreman-side validations, more on that below. policy create help says I can use scap content name, when I try I get 400, probably because content has only title, using id helps hammer policy create --hostgroup-titles default --name default --scap-content default --scap-content-profile-id 1 --period daily Could not create the policy: Error: 400 Bad Request weekday is always required even if period is daily using hostgroup titles results in following error [ERROR 2016-06-14T11:12:22 Exception] undefined method `empty?' for 1:Fixnum Could not create the policy: undefined method `empty?' for 1:Fixnum using hostgroup id results in following error Could not create the policy: You cannot call create unless the parent is saved without hostgroup specification it saves fine > > * arf-report shouldn't provide update command, probably caused by copy and > > paste, since the definition contains wrong messages anyway > > Removed. arf-report help suggest we can use name for search, ArfReport object doesn't seem to have any name attribute > > A bit unrelated but found during testing > > > * policy create help would deserve better strings, e.g. valid values for > > period (it's more about foreman_openscap API) > > > > * when there's no foreman_scap_client manifest I receive 422, it should be > > some better explanatory error > > Policy cannot be created/updated if foreman_scap_client puppet class is not > found in foreman. I improved the error handling, we should get a sane > message about what went wrong. > > Related concerns: > * Policy validation could use some improvements. Validations for scheduling > are triggered conditionally, for example 'weekday' gets validated only if > period is 'weekly'. This is fine for our UI, but it does not prevent > passing '--period monthly --day-of-month 15 --weekday $something_ugly_here' > on command line, which effectively bypasses the weekday validation. > > I plan to add search options for locs and orgs but I haven't fully figured > it out yet. > Let me know if there is anything else. > O. -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
