On Thu, Aug 25, 2016 at 03:42:04PM +0200, Ewoud Kohl van Wijngaarden wrote: > On Tue, Aug 23, 2016 at 01:40:44PM -0400, Eric D Helms wrote: > > On Tue, Aug 23, 2016 at 11:02 AM, Ewoud Kohl van Wijngaarden < > > [email protected]> wrote: > > > > > > # Katello apache fragment is mostly pulp and candlepin > > > > > > https://github.com/Katello/puppet-katello/blob/ > > > 8b4bb6924c5911fb572bb8c19667186e56c8f71b/manifests/config.pp#L25-L28 > > > > > > This sets up pulp and candlepin for which I'd propose to introduce two > > > separate fragments. > > > > > > It also manages keepalive which IMHO belongs in puppet-foreman. > > > > > > > We could look into splitting the fragments up. I want to say the keepalive > > was due to needing it and not having a way (that would get into the code > > base in time) for us to set it. This could likely be updated. > > It looks like puppetlabs-apache now has proper options for this. We even > have options for this in puppet-foreman[1] but they use a custom > fragment for this. That should get updated.
https://github.com/theforeman/puppet-foreman/pull/471 > This means we can at least drop KeepAlive On from the template. Then we > need to decide what to do with $katello::max_keep_alive which attempts > to configure the same value as $foreman::max_keepalive_requests but have > wildly differing defaults (10000 vs 100). https://github.com/Katello/puppet-katello/pull/141 -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
