----- Original Message ----- > From: "Daniel Lobato Garcia" <elobat...@gmail.com> > To: foreman-dev@googlegroups.com > Sent: Wednesday, January 11, 2017 11:05:39 AM > Subject: [foreman-dev] Revert removal of @host.params for host_param > > Hi foreman devs, > > Just noticed today https://github.com/theforeman/foreman/pull/3983/files > after some comments on IRC. What's the background behind this change? > > As far as I can see, this merely moves > > @host.param to host_param > @host.param_true? to host_param_true? > @host.param_false? to host_param_false? > @host.info to host_enc > > without gaining anything from the change. This will force people to > change their templates (including our community templates) when the > deprecation is removed, and there's nothing to gain. > > Does someone know what's the rationale behind this change? As it stands > right now, I propose reverting that commit entirely to avoid inflicting > that pain on users - which include many devs who maintain templates. > > Best, >
I know the macros look better, but it seems like a small gain for a lot of pain. A lot of users use the existing methods in parameter values (ERB w/ safe mode off), and their own custom templates. And the standard response to these kinds of complaints is "well, it's deprecated and users have enough time to change." But I really just don't think that's sufficient, this is more change for the sake of change. Also, the deprecation wasn't really smooth as it broke REX tests. http://ci.theforeman.org/job/test_plugin_matrix/2466/ - Stephen -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
