On pátek 7. dubna 2017 14:35:41 CEST John Mitsch wrote: > The greasmonkey script works great! Really helpful, thanks for sharing. For > those who are wondering (like I was), it requires the greasemonkey browser > plugin: > > https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/ or > > ttps:// > chrome.google.com/webstore/detail/tampermonkey/dhdgffkkebhmkfjojejmpbldmpobf > kfo?hl=en > > > That being said, I don't think we should have developers relying on a > script to have links to issues on a PR, I think we should have a way of > making that link available to everyone like Andrew suggested.
I agree, it would be useful for everyone. +1 if it won't generate extra mail notification, +0.5 if it will :-) -- Marek > > -John > > John Mitsch > Red Hat Engineering > (860)-967-7285 > irc: jomitsch > > On Fri, Apr 7, 2017 at 4:17 AM, Ivan Necas <ine...@redhat.com> wrote: > > Ivan Necas <ine...@redhat.com> writes: > > > Walden Raines <wrai...@redhat.com> writes: > > >> I do it manually although I probably should just write a commit hook to > > > > do > > > > >> it. > > >> > > >> I put it in the message itself because I think it's useful to have > > > > there in > > > > >> case anyone is browsing the git log or in case we ever move away from > > >> github. > > > > > > Interesting idea. Before it gets in (+ idea for other places outside of > > > prprocessor scope), I'm using Tomas's grease monkey script and has been > > > very helpful in past :) > > > > Forgot to put a link: > > https://gist.github.com/tstrachota/012d1518a08d5a9d441f > > > > -- Ivan > > > > > -- Ivan > > > > > >> Walden > > >> > > >> On Thu, Apr 6, 2017 at 5:33 PM, Andrew Kofink <akof...@redhat.com> > > > > wrote: > > >>> Walden, you have a script that adds it, or do you do it manually for > > > > every > > > > >>> issue? If the latter, then wouldn't this save you some time? ;) > > >>> > > >>> On Thu, Apr 6, 2017 at 5:24 PM, Walden Raines <wrai...@redhat.com> > > > > wrote: > > >>>> I like it although I include the links to the issues in my actual > > > > commit > > > > >>>> message so it will be doubled up in my case. > > >>>> > > >>>> > > >>>> > > >>>> On Thu, Apr 6, 2017 at 4:18 PM, John Mitsch <jomit...@redhat.com> > > > > wrote: > > >>>>> +1 from me :) > > >>>>> > > >>>>> John Mitsch > > >>>>> Red Hat Engineering > > >>>>> (860)-967-7285 <(860)%20967-7285> > > >>>>> irc: jomitsch > > >>>>> > > >>>>> On Thu, Apr 6, 2017 at 3:05 PM, Andrew Kofink <akof...@redhat.com> > > >>>>> > > >>>>> wrote: > > >>>>>> I find myself copying/pasting issue numbers from GitHub PRs to a > > >>>>>> redmine url way too much every day. It takes a bit of time, and > > >>>>>> it's > > >>>>>> annoying as well as easy to fix. > > >>>>>> > > >>>>>> I've submitted this PR to comment on a newly submitted PR with > > > > links to > > > > >>>>>> the associated issues in redmine: https://github.com/th > > >>>>>> eforeman/prprocessor/pull/59 I'd like to hear your thoughts if you > > >>>>>> have something to say about it. > > >>>>>> > > >>>>>> - Andrew > > >>>>>> > > >>>>>> -- > > >>>>>> Andrew Kofink > > >>>>>> akof...@redhat.com > > >>>>>> IRC: akofink > > >>>>>> Associate Software Engineer > > >>>>>> Red Hat Satellite > > >>>>>> > > >>>>>> -- > > >>>>>> You received this message because you are subscribed to the Google > > >>>>>> Groups "foreman-dev" group. > > >>>>>> To unsubscribe from this group and stop receiving emails from it, > > > > send > > > > >>>>>> an email to foreman-dev+unsubscr...@googlegroups.com. > > >>>>>> For more options, visit https://groups.google.com/d/optout. > > >>>>> > > >>>>> -- > > >>>>> You received this message because you are subscribed to the Google > > >>>>> Groups "foreman-dev" group. > > >>>>> To unsubscribe from this group and stop receiving emails from it, > > > > send > > > > >>>>> an email to foreman-dev+unsubscr...@googlegroups.com. > > >>>>> For more options, visit https://groups.google.com/d/optout. > > >>>> > > >>>> -- > > >>>> You received this message because you are subscribed to the Google > > > > Groups > > > > >>>> "foreman-dev" group. > > >>>> To unsubscribe from this group and stop receiving emails from it, > > > > send an > > > > >>>> email to foreman-dev+unsubscr...@googlegroups.com. > > >>>> For more options, visit https://groups.google.com/d/optout. > > >>> > > >>> -- > > >>> Andrew Kofink > > >>> akof...@redhat.com > > >>> IRC: akofink > > >>> Associate Software Engineer > > >>> Red Hat Satellite > > >>> > > >>> -- > > >>> You received this message because you are subscribed to the Google > > > > Groups > > > > >>> "foreman-dev" group. > > >>> To unsubscribe from this group and stop receiving emails from it, send > > > > an > > > > >>> email to foreman-dev+unsubscr...@googlegroups.com. > > >>> For more options, visit https://groups.google.com/d/optout. > > >> > > >> -- > > >> You received this message because you are subscribed to the Google > > > > Groups "foreman-dev" group. > > > > >> To unsubscribe from this group and stop receiving emails from it, send > > > > an email to foreman-dev+unsubscr...@googlegroups.com. > > > > >> For more options, visit https://groups.google.com/d/optout. > > > > -- > > You received this message because you are subscribed to the Google Groups > > "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to foreman-dev+unsubscr...@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
