On Thu, Jun 1, 2017 at 2:55 PM, Eric D Helms <ericdhe...@gmail.com> wrote: > This sounds good in theory, but I'll refresh the history of why we did this. > A change would be made to Foreman core, that change would go in and then > propagate out. A developer would update their foreman checkout or the > Katello pipeline would run and break. More developers start updating local > checkouts and now everyone is broken. The Katello PR tests begin to fail and > all PRs are frozen. So now a significant portion of developers are all > trying to figure out what point in time to roll back to, who is going to fix > the breakage and how long it is going to take. 1-5 days later, the issue is > fixed and PRs are able to start back up as well as the nightly pipeline. > > How much developer frustration was created? How much time was lost and > wasted? If we want core to have more freedom of movement then core needs to > evolve to allow plugins more reliability on interfacing.
Then let's don't block PRs, I propose nightly job with an email so we are at least aware that things do not work and we can at least wait with RC phase a little bit longer until things settle down, or even block doing another RC until we are all green. > I am all for more testing, but what good does testing do if there are no > consequences? A nightly test that runs and either passes or fails is > informative and requires someone to be looking and willing to act on every > change. If the test has no consequence on deployment that likelihood drops > dramatically in my opinion. I think about this a lot and how it would be Of course, but we can add an item to the release process workflow to check if nightly unit tests are all green across give set of plugins. Current way of releasing Foreman is to do two-three RCs and then go green, plugin authors are trying to catch up later. So if you are beginner user and install Foreman today, Discovery won't work as expected. It does not need to be a jenkins job, does anybody have a script that performs unit test run of foreman+katello+some plugins? -- Later, Lukas @lzap Zapletal -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
