Hello, thanks for your contribution! I'd recommend opening the PR on github with the change, that way it will get attention of more reviewers. If you're not sure about the process, please find a description at [1]. My opinion on the change is that it should change the font only for text areas that contain the YAML/ JSON, therefore in this case only when parameter type is set to YAML/JSON.
Thanks [1] https://www.theforeman.org/contribute.html#SubmitPatches -- Marek On neděle 25. června 2017 14:09:22 CEST Eric Anderton wrote: > New poster, long time Foreman user, and hopeful contributor here. > > As I've decided to take the plunge into contributing to Foreman, I figured > #10089 might be a good newbie task to pick off: > > http://projects.theforeman.org/issues/10089 - Use fixed-width font for > parameters > > """As some parameters are displayed as YAML, using a fixed-width font would > greatly ease reading and writing of such values. > Right now, indentation is too hard to get right and I usually have to edit > the parameter in an external editor then copy-paste the content in order to > avoid problems.""" > > --- > > My hunch is that this has been sitting open for two years now because > either it's really this simple, or there's some nuance here not documented > in the feature request. > > The code below sets textarea.form-control fields to monospace. Since > <input> is used in a lot of places next to controls that are styled as > Helvetica, modifying all places where .form-control is used would cause > cosmetic issues. Plus, the lack of fixed-width input today is mostly an > issue for multi-line input (AFAIK). > > Example: > https://github.com/eanderton/foreman/commit/84657c11c0893b86b922dc0b70047863 > 9ea26217 > > I'm open to any additional suggestions on this one. Any feedback? > > Thanks, > - Eric Anderton -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
