On 07/17, Daniel Lobato Garcia wrote: > On 07/14, juraj.fun...@gmail.com wrote: > > Hi, > > > > first of all, I'd like to thank you for the great work you've done so far. > > I really admire all of you guys. > > My programming skills are not so good so I'll only lend my hand in > > proposing an idea or two that might be useful. > > > > Before I run Ansible role directly I can specify certain connection > > parameters in an Ansible inventory file. > > As you know the same option is available in the Foreman GUI interface via > > parameters (Global parameters, Host group parameters etc.). > > However, there is one limitation and that is the list of parameters > > administrators can specify is limited. To get an idea which parameters are > > available > > one can take a look in the following ruby scripts > > > > /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_ansible-1.4.5/app/services/foreman_ansible/inventory_creator.rb > > and > > /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_ansible-1.4.5/app/models/setting/ansible.rb > > . > > > > The problem arise when somebody needs a parameter that is not listed there. > > Okay, you can edit both above mentioned scripts and then restart Foreman, > > but every time the official update is applied, you have to add all > > necessary code changes again. This sucks and I believe everyone agrees with > > me. > > > > So the idea I'd suggest is that, let administrators define what parameter > > they need/want without hard-coding into Foreman Ansible plugin ruby > > scripts, OR > > make them hard-coded but the list of available parameter must be complete. > > > > What do you think? > > I think it makes a lot of sense and at this point it's an easier thing > to implement than having to add a new parameter every time someone > requests it (or Ansible releases something new). I would expect > something like that for Foreman-Ansible 1.5 or 1.6
For the record, the change was already merged in https://github.com/theforeman/foreman_ansible/pull/95/files so next release will have this > > > > > > > > > > > -- > > You received this message because you are subscribed to the Google Groups > > "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to foreman-dev+unsubscr...@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. > > > -- > Daniel Lobato Garcia > > @dLobatog > blog.daniellobato.me > daniellobato.me > > GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30 > Keybase: https://keybase.io/elobato -- Daniel Lobato Garcia @dLobatog blog.daniellobato.me daniellobato.me GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30 Keybase: https://keybase.io/elobato -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: PGP signature
