On středa 1. listopadu 2017 10:19:08 CET Tomer Brisker wrote: > Hello, > This has now been merged in Foreman core. > All plugins should make sure that their respective PRs pass tests and > merge them now. If you need assistance making this change in your > plugin, please reach out to us and we would be happy to help. > > Keep in mind that any PRs that include test changes that use > FactoryGirl will need to be modified now to use FactoryBot, even if > previously the tests passed. >
Hello all, if you're uncertain whether your plugin is affected or there some action required from you, see the public pad [1]. We keep the status of the whole migration there. A lot of plugins have master branch tests broken because of rubocop update, for some plugins I sent a PR that should fix it too. This could reveal plugins that are no longer maintained :-) [1] https://pad-katello.rhcloud.com/p/factory_bot_update -- Marek > Tomer > > On Wed, Oct 25, 2017 at 4:52 PM, Marek Hulan <mhu...@redhat.com> wrote: > > Thanks for sending out the heads up. Please also note that such PRs will > > get out of date very quickly so make sure you have them up to date just > > before merge :-) > > > > -- > > Marek > > > > On October 25, 2017 3:23:29 PM Andrew Kofink <akof...@redhat.com> wrote: > >> I went ahead and made an issue for Katello [1]. I'll submit a PR today > >> with > >> the changes. > >> > >> [1] http://projects.theforeman.org/issues/21458 > >> > >> On Wed, Oct 25, 2017 at 9:12 AM, Tomer Brisker <tbris...@redhat.com> > >> > >> wrote: > >>> Hello, > >>> > >>> The Thoughtbot team have decided to rename the factory_girl gem, which > >>> we > >>> depend on for tests, to factory_bot [1]. This led to our CI breaking due > >>> to > >>> the name change. For now, we have pinned factory_girl to the last > >>> working > >>> version to unblock CI, but we should prepare to change to the new name. > >>> > >>> This requires, basically, changing every occurrence of `FactoryGirl` to > >>> `FactoryBot`, and every `factory_girl` to `factory_bot`. Other then the > >>> name change, no other changes were made to the API. > >>> > >>> Marek has opened a PR[2] for fixing this in foreman-core, however once > >>> this is merged it will break tests for all plugins depending on the core > >>> factory_girl. To prevent prolonged breakage, all plugin maintainers > >>> should > >>> work to prepare a PR making the above mentioned change, so that it can > >>> be > >>> merged once core PR is merged. > >>> > >>> To give you some time to fix this and prevent breakage, the core PR will > >>> be merged one week from today, on November 1st. Please make sure you are > >>> prepared to correctly handle this change in your plugin. If needed, feel > >>> free to reach out to me, Marek, or any of the other core maintainers. > >>> > >>> ?[1] https://github.com/thoughtbot/factory_bot/issues/921? > >>> ?[2] https://github.com/theforeman/foreman/pull/4935? > >>> > >>> -- > >>> Have a nice day, > >>> Tomer Brisker > >>> Red Hat Engineering > >>> > >>> -- > >>> You received this message because you are subscribed to the Google > >>> Groups > >>> "foreman-dev" group. > >>> To unsubscribe from this group and stop receiving emails from it, send > >>> an > >>> email to foreman-dev+unsubscr...@googlegroups.com. > >>> For more options, visit https://groups.google.com/d/optout. > >> > >> -- > >> Andrew Kofink > >> akof...@redhat.com > >> IRC: akofink > >> Software Engineer > >> Red Hat Satellite > >> > >> -- > >> You received this message because you are subscribed to the Google Groups > >> "foreman-dev" group. > >> To unsubscribe from this group and stop receiving emails from it, send an > >> email to foreman-dev+unsubscr...@googlegroups.com. > >> For more options, visit https://groups.google.com/d/optout. > > > > -- > > You received this message because you are subscribed to the Google Groups > > "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to foreman-dev+unsubscr...@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
