TL;DR: should we still keep smart class parameters when deleting the class?

When a puppet class is deleted it's smart class parameters are kept as
historical records.
If a puppet class is accidentally deleted or someone wants to see the
overrides a parameter used to have it's easy to see from the smart class
parameter that was preserved.
This is much simpler then searching for the parameter's previous state in
the audit log and might be useful in creating parameter versions.

These smart class parameters show up in the index page with no connection
to a puppet class.
There has been some confusion around the issue when duplicate records of
the same parameter appear.
Originally a bug was opened about it and rejected because this is
intentional: http://projects.theforeman.org/issues/17076.

After another issue was opened and it came up a few times on IRC it seemed
better to hide these parameters in the ui: http://projects.
theforeman.org/issues/17548.
The api wouldn't return them even before the change and if needed they can
be tracked in the db so we still have historical records but there is no
more confusion.

The reasons for keeping the smart class parameters are still valid
(accidental delete, easier then audit log, maybe possible to use as first
step towards versioning),
but we don't save the puppetclass they were connected to (so right now not
so good for versioning), the api doesn't return them and using them means
manually coping every detail.

Should we still keep them?

-- 
You received this message because you are subscribed to the Google Groups 
"Foreman users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-users+unsubscr...@googlegroups.com.
To post to this group, send email to foreman-users@googlegroups.com.
Visit this group at https://groups.google.com/group/foreman-users.
For more options, visit https://groups.google.com/d/optout.

Reply via email to