On Fri, Mar 25, 2022 at 08:03:09PM -0600, Sandra Loosemore wrote:
> I've got another patch forthcoming (stage 1 material) that adds some new
> diagnostics for non-rectangular loops during gimplification of OMP nodes.
> When I was working on that, I discovered that the Fortran front end wasn't
> attaching location information to the tree nodes corresponding to the
> various OMP directives, so the new errors weren't coming out with location
> info either. I went through trans-openmp.cc and fixed all the places where
> make_node was being called to explicitly set the location.
>
> I don't have a test case specifically for this change, but my test cases for
> the new diagnostics in the non-rectangular loops patch do exercise it. Is
> this OK for trunk now, or for stage 1 when we get there?
Ok for GCC 13.
> commit 4c745003d0b39d0e92032b62421df4920753783a
> Author: Sandra Loosemore <san...@codesourcery.com>
> Date: Thu Mar 24 21:02:34 2022 -0700
>
> Fortran: Add location info to OpenMP tree nodes
>
> gcc/fortran/
> * trans-openmp.cc (gfc_trans_omp_critical): Set location on OMP
> tree node.
> (gfc_trans_omp_do): Likewise.
> (gfc_trans_omp_masked): Likewise.
> (gfc_trans_omp_do_simd): Likewise.
> (gfc_trans_omp_scope): Likewise.
> (gfc_trans_omp_taskgroup): Likewise.
> (gfc_trans_omp_taskwait): Likewise.
> (gfc_trans_omp_distribute): Likewise.
> (gfc_trans_omp_taskloop): Likewise.
> (gfc_trans_omp_master_masked_taskloop): Likewise.
Jakub
