On Mon, Aug 29, 2022 at 11:24:52AM +0200, Tobias Burnus wrote:
> PR fortran/106670
>
> gcc/fortran/ChangeLog:
>
> * scanner.cc (skip_fixed_omp_sentinel): Add -Wsurprising warning
> for 'omx' sentinels with -fopenmp.
> * invoke.texi (-Wsurprising): Document additional warning case.
>
> libgomp/ChangeLog:
>
> * libgomp.texi (OpenMP 5.2): Add comment to ompx/omx entry.
>
> gcc/testsuite/ChangeLog:
>
> * c-c++-common/gomp/ompx-1.c: New test.
> * c-c++-common/gomp/ompx-2.c: New test.
> * g++.dg/gomp/ompx-attrs-1.C: New test.
> * gfortran.dg/gomp/ompx-1.f90: New test.
> * gfortran.dg/gomp/omx-1.f: New test.
> * gfortran.dg/gomp/omx-2.f: New test.
> --- a/libgomp/libgomp.texi
> +++ b/libgomp/libgomp.texi
> @@ -359,7 +359,13 @@ to address of matching mapped list item per 5.1, Sect.
> 2.21.7.2 @tab N @tab
> @item @code{omp_in_explicit_task} routine and @emph{implicit-task-var} ICV
> @tab N @tab
> @item @code{omp}/@code{ompx}/@code{omx} sentinels and
> @code{omp_}/@code{ompx_}
> - namespaces @tab N/A @tab
> + namespaces @tab N/A
> + @tab warning for @code{omp/ompx} sentinels@footnote{@code{omp/ompx}
> + sentinels as C/C++ pragma and C++ attributes are warned for with
> + @code{-Wunknown-pragmas} (implied by @code{-Wall}) and
> @code{-Wattributes}
> + (by default), respectively; for Fortran free-source code, the there is
> a
s/by default/enabled by default/
s/the there/there/
> + warning by default and for fixed-source code with @code{-Wsurprising}
s/by default/enabled by default/
> + (enabled by @code{-Wall})}
> @item Clauses on @code{end} directive can be on directive @tab N @tab
> @item Deprecation of no-argument @code{destroy} clause on @code{depobj}
> @tab N @tab
Otherwise LGTM.
Jakub
