Hi Andre, Thanks for resending the patches. I fear that daytime work and visitors have taken my attention the last days - hence the delay in reviewing, for which I apoloise,
The patches do what they are advertised to do, without regressions on my side. I like gfc_class_set_vptr. Please remove the commented out assert, unless you intend to deploy it. OK for mainline. Thanks for the patches. Regards Paul On Fri, 21 Jun 2024 at 07:39, Andre Vehreschild <ve...@gmx.de> wrote: > Hi Paul, > > I am sorry for the delay. I am fighting with PR96992, where Harald finds > more > and more issues. I think I am approaching that one wrongly. We will see. > > Anyway, please find attached updated version of the 2/3 and 3/3 patches, > which > apply cleanly onto master at 1f974c3a24b76e25a2b7f31a6c7f4aee93a9eaab . > > Hope that helps and thanks in advance for looking at the patches. > > Regards, > Andre > > PS. I have attached them in plain text and as archive to prevent mailers > from > corrupting them. > > On Thu, 20 Jun 2024 07:42:31 +0100 > Paul Richard Thomas <paul.richard.tho...@gmail.com> wrote: > > > Hi Andre, > > > > Both this patch and 3/3 are corrupt according to git apply: > > [pault@pc30 gcc]$ git apply --ignore-space-change --ignore-whitespace < > > ~/prs/andre/u*.patch > > error: corrupt patch at line 45 > > [pault@pc30 gcc]$ git apply --ignore-space-change --ignore-whitespace < > > ~/prs/andre/i*.patch > > error: corrupt patch at line 36 > > > > I tried messing with the offending lines, to no avail. I can apply them > by > > hand or, perhaps, you could supply me with clean patches? > > > > The patches look OK but I want to check the code that they generate. > > > > Cheers > > > > Paul > > > > > > On Tue, 11 Jun 2024 at 13:57, Andre Vehreschild <ve...@gmx.de> wrote: > > > > > Hi all, > > > > > > this patch refactors most of the locations where the _vptr of a class > data > > > type > > > is reset. The code was inconsistent in most of the locations. The goal > of > > > using > > > only one routine for setting the _vptr is to be able to later modify it > > > more > > > easily. > > > > > > The ultimate goal being that every time one assigns to a class data > type a > > > consistent way is used to prevent forgetting the corner cases. So this > is > > > just a > > > small step in this direction. I think it is worth to simplify the code > to > > > something consistent to reduce maintenance efforts anyhow. > > > > > > Regtested ok on x86_64 Fedora 39. Ok for mainline? > > > > > > Regards, > > > Andre > > > -- > > > Andre Vehreschild * Email: vehre ad gmx dot de > > > > > > -- > Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen > Tel.: +49 241 9291018 * Email: ve...@gmx.de >
