On 2/5/15, Ross Berteig <[email protected]> wrote: > > On 2/5/2015 7:55 AM, Richard Hipp wrote: >> .... See http://fossil-scm.org/index.html/timeline for the latest "look". > > Looks pretty slick. > > I deliberately taunted the Lines box, and was glad to see that "10" > produced exactly 10 entries, "5" produced five, "1" produced one. But > "0" produced (right now, likely different tomorrow) 8019 entries. I was > even more amazed that the timeline still worked with every entry ever > made to the fossil repo. I do wonder what that would look like on some > of the infamous really really big repos...
The n=N query parameter gets translated into a "LIMIT N" on the SQL query. And "LIMIT 0" means "no limit". I thought at one point about adding a javascript check to prevent a zero or negative n= value. You could still manually enter "n=0" in the URL bar. But you could also say n=1000000000 which would have about the same effect. I don't feel the need to put arbitrary limits on the size of the graph at this point. Maybe later.... > > Perhaps there should be a sanity check around 0 and "too big" values? > But I'm not sure how big is too big. > > I'm not sure that "lines" is the right word for that. Perhaps "entries" > or "items"? > > I like the proposed rename of "event" to "tech note". One thing I've > often wanted is the ability to create an event from the timeline rather > than having to remember that events are a special kind of wiki page, yet > not actually a wiki page. They are created from a link on /wiki, but do > not appear in the list of all wiki pages shown by /wcontent, and as far > as I can tell are only discoverable from entries shown on /timeline. > Perhaps there should be a "new event" (or "new tech note" if that is the > new term) button in the timeline submenu that takes you to /eventedit. Yes, I agree. I already have some notes. I need to work on the "Tech Note" mechanism. The /eventedit page needs to support mimetypes. The underlying file format already does, but the /eventedit page assumes all Tech Notes are in text/x-fossil-wiki. And the Tech-Note display needs to be enhanced. It has not been touched in many years. Thanks for reviewing the new code. > > -- > Ross Berteig [email protected] > Cheshire Engineering Corp. http://www.CheshireEng.com/ > > _______________________________________________ > fossil-dev mailing list > [email protected] > http://sqlite.org:8080/cgi-bin/mailman/listinfo/fossil-dev > -- D. Richard Hipp [email protected] _______________________________________________ fossil-dev mailing list [email protected] http://sqlite.org:8080/cgi-bin/mailman/listinfo/fossil-dev
