Hi,

fossil currently does not build in a ANSI C-89 environment - a requirement of the coding style guidelines ([1], point 16). There's an obvious build error in http_ssl.c (C++ style comments), but there's something more in sha1.c... When adding a "-std=c89" to the generated Makefile with gcc as the compiler, I end up getting (ignoring the C++ style comment at line 87)
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token
./bld/sha1_.c:104: error: expected ')' before ':' token

(and many, many, many, many more lines like that). This seems to be because of the calls to asm() ... I don't know how to fix that. FYI, after preprocessing, the first instruction of line 104 looks like:

 qq[4]+=((qq[1]&(qq[2]^qq[3]))^qq[3])+(block[0] = (({ unsigned
    int y; asm("rorl" " %1,%0" : "=r" (y) : "I" (8), "0" (block[0]));
    y; })&0xFF00FF00) |(({ unsigned int y; asm("roll" " %1,%0" :
    "=r" (y) : "I" (8), "0" (block[0])); y; })&0x00FF00FF))+0x5A827999+({
    unsigned int y; asm("roll" " %1,%0" : "=r" (y) : "I" (5), "0"
    (qq[0])); y; });

[1] http://fossil-scm.org/index.html/doc/trunk/www/style.wiki
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to