On Mon, 3 Oct 2011 14:39:18 +0200 Lluís Batlle i Rossell <virik...@gmail.com> wrote:
> > > 2. IPv6 support. Fossil uses IPv4 sockets by default. I was not > > > sure if there was any technical reason to not add support for > > > IPv6, so I modified it all relevant places (I was able to find) > > > to use IPv6 sockets, perform hostname lookups using getaddrinfo > > > (3), accept push/pulls to/from IPv6 address, and persist this > > > information in the repository database. > > That is cool, but please be sure to make such IPv6 mode not enabled > > by default unless it's somehow possible to make it work > > transparently on a conventional box with IPv4 only networking. > That's what I saw from the patch at first glance; that building with > "-DWITH_IPV6" fossil required a connected ipv6 stack. > > Additionally, I don't know how portable it is to use always > getaddrinfo (POSIX-2001?) while requiring C89. Tcl developers recently completed implementing IPv6 in the Tcl runtime, and Tcl runs even on obscure systems like AIX. So I think this should not be a problem these days. Personally I'm only concerned with this change not breaking things for the majority of users (who use IPv4 and will continue to do so in the foreseeable future). > The code could go right now into a branch, and then we change it > according to needs and tests. Good idea, thanks. _______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
