On Tue, Feb 12, 2013 at 5:42 PM, Martijn Coppoolse <
li...@martijn.coppoolse.com> wrote:

> One question: as the 'title' field doesn’t start with 'tkt_', it *could* be
> removed from the ticket table.


That thought did occur to me i figured, "nobody in their right might would
remove the title field, right?" Famous last words, of course. i.e., i
punted on that potential problem for the time being.


>  Does the `db_text` function handle SQL errors by
> returning its first parameter?
>

No - the first parameter is only the "if no such record is found" backup.
It will fail fatally with a message like "unknown column 'title'" (or
similar) if the title column is gone or has been renamed.

In such a case, it would make the info page unusable for ticket change
> records.
>

Agreed, but in the interest of speed (i was at work ;) i skipped over that.
The fossil-internal db wrapper API treats any and all sqlite3-level
failures (e.g. statement preparation failure) as fatal. In order to fix
this i'll need to bypass the internal "convenience API." It's easy enough
to do, it just needs to be done.


> I can’t seem to find the definition of `db_text` (I haven’t got a clone of
> the
> Fossil repo here at work.)
>

All(? most of) of the "db_xxxx()" functions are in db.c.

stephan@tiny:~/cvs/fossil/fossil/src$ grep 'db_text' db.c
char *db_text(char const *zDefault, const char *zSql, ...){
...


-- 
----- stephan beal
http://wanderinghorse.net/home/stephan/
http://gplus.to/sgbeal
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to