On Sat, May 4, 2013 at 12:40 AM, Matthias Toggweiler <v...@m4t.ch> wrote:
> Awesome, 5 minute reaction time on this mailing list. Thanks for the fix, > Stephan. > You're very welcome. i unfortunately don't have a quick fix for this one, though: > Now click on "Files", then on "test.html". A nice alert message appears. > Depending on the content of the HTML file, the whole UI gets screwed up. > (e.g. CSS that influences the whole page). > i _suspect_ that to properly fix this we would need to bite the bullet and add proper mime type handling to fossil (meaning the ability for a user to set the mime type for a given artifact, and to guess one by default based on e.g. the file extension). Right now fossil tries to guess mime types in a very limited manner and doesn't quite always do a/the right thing (AFAIR it only distinguishes between text/plain and binary data for the pages you mentioned). We've talked about this a couple times but it's never been enough of a problem to inspire anyone to go about adding it. That said... Proposals: > a) If you click on a file under "Files", don't show content directly. > (Stuff below the <hr>) > b) Instead, show overview information like file size. > c) Via an optional click on "Plain" or "HTML", show plain or interpreted > content. These links can go to the bar where "Checkins Using", "Download", > "Shun", "Text" reside now. > That sounds like a reasonable solution to me. The "Plain" view seems a bit redundant to me since it would presumably show the same thing as the Download link (which dumps out the raw file contents), or do you have a different interpretation of "Plain" here? We could hide the HTML link for files which fossil believes to be binary (which it determines via inspection of its content). The next 4 or 5 days i will be working overtime and probably won't get around to this, but i will keep this thread tagged for later reference when i get some free time. (If anyone else gets around to it or has objections/ideas, please drop us a note...) -- ----- stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal
_______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
