Laurens Van Houtven <[email protected]> wrote: > Hi, > > > I'd like to know what sort of code review practices Fossil users employ. I > believe this has come up at least twice: I've asked about it myself back in > 2010, and Russ Paielli from the Scala team in 2011. > > All the projects I currently work on have some explicit form of code > review, be it: > > - Github pull requests > - explicit code review processes on top of an existing tool (such as > twisted + trac) > - Launchpad merge proposals >
In my organization, code reviews are part of our process. All issues (or new features) get resolved (or implemented) on branches. AS part of the integration and test phase, the latest approved code is merge into an issue branch, code is built and tested. If it passes, another check is made for new updates to merge in. If branch is up to date, then the developer sends out a review request via email. After the changes are approved, another check for updates is made. If branch must be updated, again, the code must be reviewed, again. Otherwise, the branch is merged back in to the trunk as approved code.
_______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
