2014-03-05 7:51 GMT+01:00 Andy Bradford <amb-fos...@bradfords.org>:
> Also, clicking the button to reveal the non-whitespace change
> is no more ``correct'' than if Joel had instead changed ``Listening'' to
> ``listening'' on one of those lines. It would still show Joel as the
> ``author'' of that line, but really he simply made a minor modification
> to it while drh was the original author. Should Fossil be concerned
> about authors of bytes in annotate/blame?
Sorry, I respectfully disagree. Changing "Listening" to "listening" is
a real change inside the string, indentation (sol-whitespace) and
eol-whitespace (such as \r preceding \n) is generally considered
irrelevant for annotation, because it is before/after the 'actual' line.
In-between spacing, that's a different issue: Git's "blame" command
has a -w option for that purpose.... which
is much different from what you are proposing).
Actually, the "-w" option added to the diff commands/pages is
not 100% equal to git's "-w" option either: In git it means
--ignore-all-space, which is more forgiving than the sum of
-ignore-space-at-sol and --ignore-space-at-eol. Fossil could
be extended to handle the --ignore-all-space and
--ignore-space-change options too, but I don't think anyone
would note the difference. I consider this out-of-scope for the
"diff-eolws" branch (which should have been named
"diff-solws-and-eolws"......)
I think the "diff-eolws" is good to be merged to trunk (the annotation
indenting bug is fixed now), but I wait for Joel (and possible other
people interested)'s judgement.
Happy testing!
Regards,
Jan Nijtmans
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
